Various keyboard protocol handling fixes #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives better key reporting for XTerm and strict clones that implement the modifyOtherKeys (CSI-27-~) protocol.
e9347ab to
6c49349
Compare
…aks some keys The encoding for things like SS3 sequences used in terminals like WezTerm and Alacritty breaks the processor, since the CSI state machine changes interferes with the SS3 state. We introduce a nested state machine for this case. Note that ConEmu still seems busted when running locally, although it is interesting that using it from an SSH hosted session works well. Nonetheless, we don't recommend ConEmu for a variety of reasons.
6c49349 to
0b5424d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems with win32-input-mode and some third party emulators, addresses compatibility for Control key processing, and adds greatly improved keyboard support for genuine XTerm.