Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 25, 2024

😬

The testsuite is there, but Spark is completely missing from tox.ini and it's also not run in CI.

@sentrivana sentrivana added Component: Tests Dealing with tests Component: CI Dealing with Github Actions labels Jun 25, 2024
@sentrivana sentrivana changed the title fix(tests): Test Spark integration in CI fix(tests): Add Spark to tox.ini and to CI Jun 25, 2024
@sentrivana sentrivana changed the title fix(tests): Add Spark to tox.ini and to CI fix(tests): Add Spark testsuite to tox.ini and to CI Jun 25, 2024
@sentrivana sentrivana marked this pull request as ready for review June 25, 2024 11:34
@sentrivana sentrivana requested review from antonpirker and szokeasaurusrex and removed request for szokeasaurusrex June 25, 2024 11:34
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, please address the inline question before merging

@sentrivana sentrivana merged commit bcc563c into master Jun 25, 2024
@sentrivana sentrivana deleted the ivana/test-spark branch June 25, 2024 11:51
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: CI Dealing with Github Actions Component: Tests Dealing with tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants