Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ggrossetie
Copy link
Owner

resolves #39

@mariotoffia
Copy link

Hi and thanks @Mogztter for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?

... or is it this environment variable - period? :)

Cheers,
Mario :)

@ggrossetie
Copy link
Owner Author

Hey @mariotoffia

Hi and thanks @Mogztter for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?

No, it will only be an environment variable but 100 MB should be more than enough.
This hard limit is specific to Node.js (JavaScript runtime) and not tied to Kroki or Asciidoctor so it does not make sense to introduce a setting or an AsciiDoc attribute.

If you are working with diagrams that are larger than 100 MB then you probably need to fine tune your runtime environment (Node.js) hence the environment variable.

@ggrossetie ggrossetie merged commit b648a39 into master Feb 9, 2021
@ggrossetie ggrossetie deleted the issue-39-max-buffer branch February 9, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spawnSync /bin/sh ENOBUFS is thrown when the POST data is greater than 1 megabytes

3 participants