refactor: use single internal args buffer #1286
Merged
+33
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 27, 2025
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the internal storage mechanism by replacing separate arrays for snapshots and delimiters with a unified "box" storage system. The refactoring consolidates two distinct internal buffers into a single reusable container that handles both snapshot and delimiter storage through a type-safe interface.
- Replaces separate
snapshotsanddelimitersarrays with a unifiedboxstorage mechanism - Introduces a new storage API with
pushandlootmethods for managing internal state - Updates all references to use the new unified storage system
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core.ts | Implements the new unified box storage system and updates all snapshot/delimiter usage |
| build/core.cjs | Generated build file reflecting the TypeScript changes |
| test/core.test.js | Fixes error class reference from custom Err to standard Error |
| .size-limit.json | Updates bundle size limits to accommodate the refactoring changes |
Comments suppressed due to low confidence (2)
src/core.ts:165
- [nitpick] The variable name 'box' is ambiguous and doesn't clearly indicate its purpose as an internal storage mechanism. Consider renaming to something more descriptive like 'internalStorage' or 'argsBuffer'.
const box = (<B extends Snapshot | Snapshot['delimiter']>(box: B[] = []) => ({
src/core.ts:170
- [nitpick] The method name 'loot' is unclear and doesn't convey its purpose as a data retrieval operation. Consider using a more descriptive name like 'pop', 'take', or 'retrieve'.
loot: box.pop.bind(box) as <T extends B>() => T | undefined,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.