fix(cli): filter npm install flags
#1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Aug 7, 2025
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of npm install flags by refactoring how optional flags are managed. Instead of concatenating empty strings when flags are not needed, it now uses an array-based approach with filtering to ensure only valid flags are passed to the npm command.
- Replaces string concatenation with array-based flag management
- Uses
filter(Boolean)to remove falsy values (null/undefined flags) - Maintains the same functionality while improving code clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/deps.ts | Refactors npm installer to use array-based flag filtering instead of string concatenation |
| build/deps.cjs | Contains the compiled version of the TypeScript changes with the same flag filtering logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.