Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(logcli): add --log.level parameter #19136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poyzannur merged 5 commits into from
Oct 2, 2025
Merged

feat(logcli): add --log.level parameter #19136

poyzannur merged 5 commits into from
Oct 2, 2025
+9 −0

Conversation

@bboreham
Copy link
Contributor

@bboreham bboreham commented Sep 9, 2025

What this PR does / why we need it:

To help with diagnosing errors when using logcli.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
It feels a little ugly to pull in dskit references in a command-line program. Open to any suggestions of other ways to do it.

Also I'm not sure if the default setting of error will log anything new that users don't want to see.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • NA Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • NA Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • NA If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@bboreham
Logcli: add --log.level parameter
4931c7a 
To help with diagnosing errors when using logcli.
@bboreham bboreham requested a review from a team as a code owner September 9, 2025 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025 •
edited
Loading

💻 Deploy preview deleted.

@bboreham
Copy link
Contributor Author

bboreham commented Sep 9, 2025

Error: No release type found in pull request title "feat [logcli]: add --log.level parameter". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

I did read that page and tried to follow its advice. Are scopes not allowed?

@slim-bean slim-bean changed the title feat [logcli]: add --log.level parameter feat(logcli): add --log.level parameter Sep 9, 2025
@slim-bean
Copy link
Collaborator

slim-bean commented Sep 9, 2025

I guess the syntax is a bit different, feat(logcli) vs feat[logcli]

@bboreham
Copy link
Contributor Author

bboreham commented Sep 10, 2025

Thanks, I now see the confusion. In the summary <type>[optional scope]: <description>, the square brackets are meta-syntax.
The real specification says "4. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):"

@poyzannur poyzannur merged commit 77c18d9 into main Oct 2, 2025
65 checks passed
@poyzannur poyzannur deleted the logcli-loglevel branch October 2, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bboreham @slim-bean @poyzannur