feat(grpc): server codegen using protobuf rust #2359
Merged
+758
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53919c3 to
f99dd76
Compare
f99dd76 to
2bac02c
Compare
14e9aba to
422f9dd
Compare
dfawley
approved these changes
Aug 15, 2025
LucioFranco
approved these changes
Aug 22, 2025
Member
LucioFranco
left a comment
There was a problem hiding this comment.
LGTM, I just have a few comments left inline.
| # Avoid unbound variable errors on MacOS with bash version < 4.4. | ||
| # See: https://stackoverflow.com/a/61551944 | ||
| flags+=( ${TLS_ARRAY[@]+"${TLS_ARRAY[@]}"} ) | ||
| interop/bin/client_"${OS}"_amd64"${EXT}" "${flags[@]}" |
Member
There was a problem hiding this comment.
Can we also make it so we can mix and match codecs here with the client?
| R"rs( | ||
| $trait_doc$ | ||
| #[async_trait] | ||
| pub trait $server_trait$ : std::marker::Send + std::marker::Sync + 'static { |
Member
There was a problem hiding this comment.
Suggested change
| pub trait $server_trait$ : std::marker::Send + std::marker::Sync + 'static { | |
| pub trait $server_trait$: std::marker::Send + std::marker::Sync + 'static { |
Is this space needed? When we use quote we need this for its interpolation but I don't think the c++ stuff needs that?
| static void GenerateMethods(Printer &printer, const Service &service, | ||
| const GrpcOpts &opts) { | ||
| static const std::string unary_format = R"rs( | ||
| #[allow(non_camel_case_types)] |
Member
There was a problem hiding this comment.
I don't think we have this with the other codegen, why do we need this here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds server code generation using Protobuf Rust. To test the generated code, a Go client and a Tonic client using Prost are used to run interop tests against the Tonic server implemented with Protobuf Rust.
Note: The generated code uses
generate_default_stubs = true, consistent with other gRPC implementations. This avoids breaking builds when a new method is added to the.protofile. In practice, this means that the server trait does not include associated types for response streams.