fix: empty and nil slice handling #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix handling of empty and nil slices. There are scenarios where empty slices get turned into slices of 1 element, and where nil slices cause a panic.
This PR fixes these scenarios.
How did I test it?
Added unit tests that demonstrate various scenarios, some of which fail before the fix and pass with the fix.
Notably:
TestDecoder_UnionInterfaceArrayEmptyTestDecoder_UnionArrayRecordEmptyTestDecoder_UnionInterfaceArrayRecordEmptyTestEncoder_UnionInterfaceUnregisteredArrayNullmap[string]anypanicked instead of encoding an empty slice