Thanks to visit codestin.com
Credit goes to github.com

Skip to content

R/aws billing views: Add new resource for custom billing view #45097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
subham-ibmhc merged 12 commits into from
Nov 20, 2025
Merged

R/aws billing views: Add new resource for custom billing view #45097

subham-ibmhc merged 12 commits into from
Nov 20, 2025

Conversation

@subham-ibmhc
Copy link
Contributor

@subham-ibmhc subham-ibmhc commented Nov 17, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds new resource for AWS custom billing view.

Relations

Closes #40677

References

https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_billing_CreateBillingView.html
https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_billing_GetBillingView.html
https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_billing_UpdateBillingView.html
https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_billing_DeleteBillingView.html

Output from Acceptance Testing

% make testacc TESTS=TestAccBillingView_ PKG=billing
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_billing_views 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/billing/... -v -count 1 -parallel 20 -run='TestAccBillingView_'  -timeout 360m -vet=off
2025/11/14 21:06:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/14 21:06:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBillingView_basic
=== PAUSE TestAccBillingView_basic
=== RUN   TestAccBillingView_update
=== PAUSE TestAccBillingView_update
=== RUN   TestAccBillingView_disappears
=== PAUSE TestAccBillingView_disappears
=== CONT  TestAccBillingView_basic
=== CONT  TestAccBillingView_disappears
=== CONT  TestAccBillingView_update
--- PASS: TestAccBillingView_disappears (23.41s)
--- PASS: TestAccBillingView_basic (26.88s)
--- PASS: TestAccBillingView_update (57.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/billing    62.546s

...

@subham-ibmhc
add models
b8faaf7
@subham-ibmhc
fix model and schema
cb169c4
@subham-ibmhc
update crud functions, add generate directive, add status and waiter …
39640e6 
…functions
@subham-ibmhc
patched errors in update
ca95171
@subham-ibmhc
add sweeper
4268ba4
@subham-ibmhc
r/aws_billing_view: Adds new resource to AWS billing view
4689555 
% make testacc TESTS=TestAccBillingView_ PKG=billing
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_billing_views 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/billing/... -v -count 1 -parallel 20 -run='TestAccBillingView_'  -timeout 360m -vet=off
2025/11/14 21:06:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/14 21:06:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBillingView_basic
=== PAUSE TestAccBillingView_basic
=== RUN   TestAccBillingView_update
=== PAUSE TestAccBillingView_update
=== RUN   TestAccBillingView_disappears
=== PAUSE TestAccBillingView_disappears
=== CONT  TestAccBillingView_basic
=== CONT  TestAccBillingView_disappears
=== CONT  TestAccBillingView_update
--- PASS: TestAccBillingView_disappears (23.41s)
--- PASS: TestAccBillingView_basic (26.88s)
--- PASS: TestAccBillingView_update (57.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/billing    62.546s
@subham-ibmhc
add resource tag lookup, add documentation
0a07688
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. generators Relates to code generators. service/billing Issues and PRs that pertain to the billing service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels Nov 17, 2025
jar-b
jar-b reviewed Nov 17, 2025
View reviewed changes
@subham-ibmhc subham-ibmhc added the rnd-ind-provider rnd-ind-provider label Nov 19, 2025
@subham-ibmhc subham-ibmhc marked this pull request as ready for review November 19, 2025 10:33
@subham-ibmhc subham-ibmhc requested a review from a team as a code owner November 19, 2025 10:33
jar-b
jar-b reviewed Nov 19, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple nits and question on create and update flex.Flatten calls.

jar-b
jar-b approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t K=billing T=TestAccBillingView_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 r/aws_billing_views 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/billing/... -v -count 1 -parallel 20 -run='TestAccBillingView_'  -timeout 360m -vet=off
2025/11/19 13:12:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/19 13:12:30 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccBillingView_disappears (14.14s)
--- PASS: TestAccBillingView_basic (16.55s)
--- PASS: TestAccBillingView_update (28.75s)
--- PASS: TestAccBillingView_tags (33.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/billing    40.020s

@subham-ibmhc subham-ibmhc merged commit 3fda499 into hashicorp:main Nov 20, 2025
46 of 49 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.22.0 milestone Nov 20, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

This functionality has been released in v6.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@henkka henkka mentioned this pull request Nov 27, 2025
Open
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. rnd-ind-provider rnd-ind-provider service/billing Issues and PRs that pertain to the billing service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.22.0

Development

Successfully merging this pull request may close these issues.

[New]: Resources for Custom Billing View

2 participants

@subham-ibmhc @jar-b