Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@johnsonaj
Copy link
Member

@johnsonaj johnsonaj commented Dec 1, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Add aws_lambda_capacity_provider resource
  • Add support for capacity provider to aws_lambda_function

Relations

Closes #45332

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLambdaCapacityProvider_' PKG=lambda P=10

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-lambda_capacity_provider 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/lambda/... -v -count 1 -parallel 10  -run=TestAccLambdaCapacityProvider_ -timeout 360m -vet=off
2025/12/01 13:17:02 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 13:17:02 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccLambdaCapacityProvider_disappears (54.48s)
--- PASS: TestAccLambdaCapacityProvider_basic (55.21s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_emptyProviderOnlyTag (58.00s)
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Replace (74.97s)
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnCreate (77.74s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_updateToProviderOnly (78.45s)
--- PASS: TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_DefaultTag (88.49s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_overlapping (105.74s)
--- PASS: TestAccLambdaCapacityProvider_tags (114.44s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_providerOnly (125.74s)
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnCreate (60.10s)
--- PASS: TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_ResourceTag (85.53s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_emptyResourceTag (55.08s)
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Add (88.60s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nonOverlapping (96.16s)
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Replace (75.22s)
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Add (74.52s)
--- PASS: TestAccLambdaCapacityProvider_scalingConfig (65.34s)
--- PASS: TestAccLambdaCapacityProvider_instanceRequirements (72.01s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nullNonOverlappingResourceTag (54.62s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_updateToResourceOnly (70.79s)
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyMap (53.44s)
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nullOverlappingResourceTag (53.93s)
--- PASS: TestAccLambdaCapacityProvider_tags_null (52.79s)
--- PASS: TestAccLambdaCapacityProvider_tags_AddOnUpdate (66.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	218.124s
% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_capacityProvider' PKG=lambda

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-lambda_capacity_provider 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunctionDataSource_capacityProvider -timeout 360m -vet=off
2025/12/01 13:24:17 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 13:24:17 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaFunctionDataSource_capacityProvider
=== PAUSE TestAccLambdaFunctionDataSource_capacityProvider
=== CONT  TestAccLambdaFunctionDataSource_capacityProvider
--- PASS: TestAccLambdaFunctionDataSource_capacityProvider (421.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	429.414s
% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_capacityProvider' PKG=lambda

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-lambda_capacity_provider 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunctionDataSource_capacityProvider -timeout 360m -vet=off
2025/12/01 12:59:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 12:59:55 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaFunctionDataSource_capacityProvider
=== PAUSE TestAccLambdaFunctionDataSource_capacityProvider
=== CONT  TestAccLambdaFunctionDataSource_capacityProvider
--- PASS: TestAccLambdaFunctionDataSource_capacityProvider (378.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	385.892s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 1, 2025
@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Dec 1, 2025
@johnsonaj johnsonaj marked this pull request as ready for review December 1, 2025 21:23
@johnsonaj johnsonaj requested a review from a team as a code owner December 1, 2025 21:23
@johnsonaj johnsonaj force-pushed the f-lambda_capacity_provider branch from 25788ec to 11ad872 Compare December 2, 2025 01:36
ewbankkit
ewbankkit previously approved these changes Dec 2, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaCapacityProvider_\|TestAccLambdaFunction_capacityProvider\|TestAccLambdaFunction_basic\|TestAccLambdaFunctionDataSource_capacityProvider\|TestAccLambdaFunctionDataSource_basic' PKG=lambda ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-lambda_capacity_provider 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/lambda/... -v -count 1 -parallel 4  -run=TestAccLambdaCapacityProvider_\|TestAccLambdaFunction_capacityProvider\|TestAccLambdaFunction_basic\|TestAccLambdaFunctionDataSource_capacityProvider\|TestAccLambdaFunctionDataSource_basic -timeout 360m -vet=off
2025/12/02 09:35:39 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/02 09:35:39 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaCapacityProvider_tags
=== PAUSE TestAccLambdaCapacityProvider_tags
=== RUN   TestAccLambdaCapacityProvider_tags_null
=== PAUSE TestAccLambdaCapacityProvider_tags_null
=== RUN   TestAccLambdaCapacityProvider_tags_EmptyMap
=== PAUSE TestAccLambdaCapacityProvider_tags_EmptyMap
=== RUN   TestAccLambdaCapacityProvider_tags_AddOnUpdate
=== PAUSE TestAccLambdaCapacityProvider_tags_AddOnUpdate
=== RUN   TestAccLambdaCapacityProvider_tags_EmptyTag_OnCreate
=== PAUSE TestAccLambdaCapacityProvider_tags_EmptyTag_OnCreate
=== RUN   TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_providerOnly
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_providerOnly
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_overlapping
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_overlapping
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLambdaCapacityProvider_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLambdaCapacityProvider_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLambdaCapacityProvider_tags_ComputedTag_OnCreate
=== PAUSE TestAccLambdaCapacityProvider_tags_ComputedTag_OnCreate
=== RUN   TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLambdaCapacityProvider_basic
=== PAUSE TestAccLambdaCapacityProvider_basic
=== RUN   TestAccLambdaCapacityProvider_disappears
=== PAUSE TestAccLambdaCapacityProvider_disappears
=== RUN   TestAccLambdaCapacityProvider_instanceRequirements
=== PAUSE TestAccLambdaCapacityProvider_instanceRequirements
=== RUN   TestAccLambdaCapacityProvider_scalingConfig
=== PAUSE TestAccLambdaCapacityProvider_scalingConfig
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_capacityProvider
=== PAUSE TestAccLambdaFunctionDataSource_capacityProvider
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_capacityProvider
=== PAUSE TestAccLambdaFunction_capacityProvider
=== CONT  TestAccLambdaCapacityProvider_tags
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccLambdaCapacityProvider_disappears
=== CONT  TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLambdaCapacityProvider_disappears (47.46s)
=== CONT  TestAccLambdaCapacityProvider_basic
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nullNonOverlappingResourceTag (51.16s)
=== CONT  TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_DefaultTag (73.20s)
=== CONT  TestAccLambdaFunctionDataSource_capacityProvider
--- PASS: TestAccLambdaCapacityProvider_basic (47.99s)
=== CONT  TestAccLambdaFunction_capacityProvider
--- PASS: TestAccLambdaCapacityProvider_tags (98.57s)
=== CONT  TestAccLambdaFunction_basic
--- PASS: TestAccLambdaCapacityProvider_tags_IgnoreTags_Overlap_ResourceTag (75.30s)
=== CONT  TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLambdaFunction_basic (40.85s)
=== CONT  TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Add (65.79s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnUpdate_Replace (65.17s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccLambdaFunction_capacityProvider (128.29s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_updateToResourceOnly (64.02s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_overlapping
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nonOverlapping (85.25s)
=== CONT  TestAccLambdaCapacityProvider_tags_ComputedTag_OnCreate
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_updateToProviderOnly (64.39s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccLambdaCapacityProvider_tags_ComputedTag_OnCreate (53.11s)
=== CONT  TestAccLambdaCapacityProvider_scalingConfig
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_nullOverlappingResourceTag (50.02s)
=== CONT  TestAccLambdaFunctionDataSource_basic
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_overlapping (86.92s)
=== CONT  TestAccLambdaCapacityProvider_tags_EmptyTag_OnCreate
--- PASS: TestAccLambdaFunctionDataSource_basic (34.86s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccLambdaCapacityProvider_scalingConfig (60.67s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_providerOnly
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnCreate (65.82s)
=== CONT  TestAccLambdaCapacityProvider_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_emptyResourceTag (50.29s)
=== CONT  TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_emptyProviderOnlyTag (50.21s)
=== CONT  TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccLambdaFunctionDataSource_capacityProvider (401.90s)
=== CONT  TestAccLambdaCapacityProvider_tags_EmptyMap
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Replace (62.37s)
=== CONT  TestAccLambdaCapacityProvider_tags_null
--- PASS: TestAccLambdaCapacityProvider_tags_DefaultTags_providerOnly (106.26s)
=== CONT  TestAccLambdaCapacityProvider_tags_AddOnUpdate
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyMap (49.74s)
=== CONT  TestAccLambdaCapacityProvider_instanceRequirements
--- PASS: TestAccLambdaCapacityProvider_tags_null (48.95s)
--- PASS: TestAccLambdaCapacityProvider_tags_EmptyTag_OnUpdate_Add (77.57s)
--- PASS: TestAccLambdaCapacityProvider_tags_AddOnUpdate (61.67s)
--- PASS: TestAccLambdaCapacityProvider_instanceRequirements (67.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	597.889s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit e7b0ab1 into main Dec 2, 2025
67 checks passed
@johnsonaj johnsonaj deleted the f-lambda_capacity_provider branch December 2, 2025 17:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.24.0 milestone Dec 2, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This functionality has been released in v6.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda Managed Instances

2 participants