Add x, y parameters to getBoundingClientRect #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Although the general plan for these not-very-good mocks is still up in the air (see #2751), this seems like a reasonable improvement assuming CI passes, so I'll merge it pending further discussion on that point. |
Member
|
Looks like this requires a few test updates. |
Contributor
Author
|
@domenic sorry for the delay on this- I had trouble getting tests to run locally. I updated the "build" tests so they should pass now, but I couldn't figure out why "build-with-canvas" was failing with a segmentation fault. Let me know if this is expected, or if there is further action that needs to be done on my part. |
TimothyGu
approved these changes
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBoundingClientRectreturns a DOMRect which is supposed to have anxandyproperty. This change makesgetBoundingClientRectbehave more reliably for code which expects its properties to have defined numerical values.fixes #3188