LuaLexer: Lex variables, properties, and function calls #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05a3dcc to
10bce1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
LuaLexerin that it can now detect variables, properties, and function calls. Accesses and/or calls likefoo.bar:baz()now yield (excluding punctuation) variable, property, function. This required refactoring the detection of builtins (first commit).One thing the lexer gets slightly wrong is that it will yield "variable" for table properties (
{ foo = 1 }). Detecting this would require much more state (essentially for every scope).The lexer now also makes use of
Text.Whitespace.