Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fisker
Copy link
Member

@fisker fisker commented Nov 27, 2023

Description

Fixes #15699

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review November 28, 2023 01:48
@fisker fisker requested a review from sosukesuzuki November 28, 2023 01:49
}
}

// In TypeScript, we can't distinguish `with`/`assert`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have not been able to research this yet. If you know, please let me know.
Is this a problem with TypeScript Compiler? Or is it a typescript-estree issue? If it is a typescript-estree issue, is there any way to fix the parser side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think typescript-estree cares about it, I think typescript treat them the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for import attributes with TypeScript

3 participants