fix(remotewrite2): do not overwrite help text with unit in enqueue#15825
Merged
fix(remotewrite2): do not overwrite help text with unit in enqueue#15825
Conversation
While testing POC for grafana/mimir#9072 I saw no unit or help metadata. Our test env: https://github.com/grafana/mimir/tree/main/development/mimir-monolithic-mode doesn't have units, so that was empty and cleared the help due to this bug. Signed-off-by: György Krajcsovits <[email protected]>
beorn7
approved these changes
Jan 14, 2025
Member
beorn7
left a comment
There was a problem hiding this comment.
Ooof, clearly, a lack of unit tests. ;)
bwplotka
approved these changes
Jan 15, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! Yea, units are not well covered, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing POC for grafana/mimir#9072 I saw no unit or help metadata.
Our test env: https://github.com/grafana/mimir/tree/main/development/mimir-monolithic-mode doesn't have units, so that was empty and cleared the help metadata due to this bug.