fix accounting for lost RESET_STREAM frames in the send stream #4804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4804 +/- ##
==========================================
+ Coverage 83.86% 83.88% +0.02%
==========================================
Files 149 149
Lines 16052 16053 +1
==========================================
+ Hits 13462 13466 +4
+ Misses 2059 2056 -3
Partials 531 531 ☔ View full report in Codecov by Sentry. |
d194541 to
79877cd
Compare
Member
Author
|
I just merged #4799, so this PR is ready to go 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4803.
This PR won't be merged before #4799, as I want to have decent tests for this, and I'm not going to write any more Ginkgo tests.