metrics: add Prometheus metrics for sent and received packets #4910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4910 +/- ##
==========================================
+ Coverage 83.60% 83.92% +0.32%
==========================================
Files 152 152
Lines 16253 16389 +136
==========================================
+ Hits 13587 13753 +166
+ Misses 2138 2111 -27
+ Partials 528 525 -3 ☔ View full report in Codecov by Sentry. |
198ed14 to
9dd9d45
Compare
9dd9d45 to
10fe96f
Compare
fda353c to
98c45ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only covers packets sent and received within a QUIC connection (i.e. for example, it doesn't cover Retry and Version Negotiation packets sent by the server).
Downside to this PR: This now causes allocations when metrics collection is enabled, as the connection needs to prepare a slice of frames (see #4915).