qlog: rework the ConnectionClosed event #5417
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ConnectionClosed qlog event structure to replace error object introspection with explicit field-based representation. Instead of passing an error interface and using errors.As() to determine the type and extract details, the event now directly accepts structured fields like Initiator, ConnectionError, ApplicationError, Reason, and Trigger.
Key changes:
- Replaced error-based
ConnectionClosedevent with explicit typed fields - Added type aliases for
TransportErrorCodeandApplicationErrorCodeto qlog package - Introduced
ConnectionCloseTriggerenum for idle_timeout, application, version_mismatch, and stateless_reset scenarios - Updated encoding logic to use switch statements on error codes instead of error type assertions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| qlog/types.go | Added type aliases for error codes and new ConnectionCloseTrigger enum type with constants |
| qlog/event.go | Refactored ConnectionClosed struct and encoding logic to use explicit fields instead of error introspection |
| qlog/event_test.go | Updated tests to construct ConnectionClosed events with explicit fields; removed handshake timeout test as it's now handled same as idle timeout |
| connection_test.go | Updated test assertions to construct expected qlog events with explicit structured fields |
| connection.go | Modified handleCloseError to extract error details and construct qlog event with explicit fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
602cf78 to
78ad817
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.