Unify all precision validation to be consistent with BigDecimal#add #442
+74
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigMath methods was aligned with BigMath.log precision handling that raises "precision must be an Integer" for non-integers. This is different from BigDecimal#add handling that converts with to_int. This commit unifies all precision handling to match BigDecimal#add series. In addition, bigdecimal tests in ruby/spec requires non-integer precision to be accepted.
4c0a80a to
2830efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigMath methods was aligned with BigMath.log precision handling that raises "precision must be an Integer" for non-integers.
This is different from BigDecimal#add handling that converts with to_int. This commit unifies all precision handling to match BigDecimal#add series.
In addition, bigdecimal tests in ruby/spec requires non-integer precision to be accepted.
Round (BigDecimal and Float) also accepts non-integer ndigits