Respect db config query_cache in railtie executor hook
#53484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have documented the ability to disable the query cache from db config, as well as implicitly being able to modify the size of the cache:
rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
Lines 121 to 129 in 8c80b02
This was added in #48110.
When updating an app to Rails 7.1, we wanted to keep using the cache unbounded while we put in place the proper instrumentation for observing that change.
Here is a full reproducible script:
/cc @byroot