Trigger search modal on "Search docs" input focus #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression introduced in #1601 This PR triggers the search modal when clicking on the "Search docs" input from - inside the flyout if present - the top left navbar
ericholscher
approved these changes
Oct 1, 2024
Member
ericholscher
left a comment
There was a problem hiding this comment.
Seems that we just moved this outside the if block? Is there any more context on why that fixes it?
Member
Author
|
Yes. We moved it away from the first block because that block is only executed when |
agjohnson
approved these changes
Oct 1, 2024
Member
Author
|
I released 3.0.0rc4 with this work: https://pypi.org/project/sphinx-rtd-theme/3.0.0rc4/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression introduced in
#1601
This PR triggers the search modal when clicking on the "Search docs" input from