feat: add types for getting and setting contact property values #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/contacts/interfaces/get-contact.interface.ts">
<violation number="1" location="src/contacts/interfaces/get-contact.interface.ts:21">
The fallback `{ type: string; value: unknown }` branch widens the union so TypeScript will happily accept `{ type: 'number', value: 'oops' }`, defeating the new type-safety guarantee for property values.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
32c74c6 to
1ba08fb
Compare
1ba08fb to
6349e4b
Compare
cassiozen
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the return type of GET /contacts to include custom properties, as well as the input types for POST and PATCH /contacts to accept property values.
Summary by cubic
Adds typed support for contact custom properties. GET now includes typed property values, and POST/PATCH accept property inputs.