Do not mark variable access in files without side effects as TDZ#4866
Merged
lukastaegert merged 1 commit intomasterfrom Feb 18, 2023
Merged
Do not mark variable access in files without side effects as TDZ#4866lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4808-cross-module-TDZsor load it into the REPL: |
d137ed1 to
587510e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4866 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 219 219
Lines 7943 7943
Branches 2189 2188 -1
=======================================
Hits 7862 7862
Misses 26 26
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
This PR has been released as part of [email protected]. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The logic to deoptimize variables when accessed in their temporal dead zone did not take module boundaries into account, leading to falsely deoptimized variables and wrongly attributed side effects.