Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Aug 1, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

There is a bug when using optional chaining on namespaces which is fixed here, see test case.

cc @FlorianRohm

@vercel
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 8:03am

@github-actions
Copy link

github-actions bot commented Aug 1, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-chained-namespace-literal-value

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-5ey1bwd0z-rollup-js.vercel.app/repl/?pr=5597

@github-actions
Copy link

github-actions bot commented Aug 1, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.453 ± 0.066 9.383 9.513 1.01 ± 0.01
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.398 ± 0.040 9.352 9.428 1.00

Internal benchmark

  • BUILD: 8370ms, 752 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3224ms, 575 MB
      • generate ast: 1546ms, 568 MB
    • sort and bind modules: 458ms, 617 MB
    • mark included statements: 4684ms, 752 MB
      • treeshaking pass 1: 1594ms, 717 MB
      • treeshaking pass 2: 768ms, 738 MB
      • treeshaking pass 3: 302ms, 747 MB
      • treeshaking pass 4: 280ms, 744 MB
      • treeshaking pass 5: 323ms, 750 MB
      • treeshaking pass 6: 267ms, 748 MB
      • treeshaking pass 7: 246ms, 749 MB
      • treeshaking pass 8: 238ms, 752 MB
      • treeshaking pass 9: 216ms, 756 MB
      • treeshaking pass 10: 219ms, 754 MB
      • treeshaking pass 11: 217ms, 752 MB
  • GENERATE: 901ms, 1.02 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 86ms, 919 MB
      • optimize chunks: 0ms, 917 MB
    • render chunks: 794ms, 1 GB (+2%)
    • transform chunks: 19ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (8b96791) to head (7d3fb04).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5597   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         242      242           
  Lines        9304     9308    +4     
  Branches     2463     2465    +2     
=======================================
+ Hits         9216     9220    +4     
  Misses         58       58           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 7625d3e into master Aug 1, 2024
@lukastaegert lukastaegert deleted the fix-chained-namespace-literal-value branch August 1, 2024 08:21
@github-actions
Copy link

github-actions bot commented Aug 1, 2024

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant