-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix retrieval of literal values for chained namespaces #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix-chained-namespace-literal-valueNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5597 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 242 242
Lines 9304 9308 +4
Branches 2463 2465 +2
=======================================
+ Hits 9216 9220 +4
Misses 58 58
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of [email protected]. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
There is a bug when using optional chaining on namespaces which is fixed here, see test case.
cc @FlorianRohm