Testing: unify http client mock #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It adds a lot of complexity / opportunity to get things wrong in our testing framework that you always have to specify
http_client_mock_streamingvshttp_client_mock(and in the beta branch, it balloons and you havehttp_client_mock_asyncandhttp_client_mock_streaming_async). This PR changes HTTPClientMock, instead of constructing it withis_streamingand this determining whichself.funcwas set, we instead haveself.funcsand combine the mocking functionality to operate over multiple mocked functions.