[1.x] Use generic early output file name #7830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
commented
Oct 25, 2024
eed3si9n
reviewed
Oct 25, 2024
749bc8f to
4beb78b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While analysis is stored as
inc_compile.zip, early output has elaborate file name such asproject_3-0.1.0-SNAPSHOT.jar. Since the file name contains version, as a result for user withGitVersioningplugin, the version changes every commit therefore due to file name mismatch Zinc forces full recompilation.Solution
Use a generic filename. Since
inc_compile.zipdid not seem to have caused any problem, this PR changes early output file name toearly.jar.Closes #7767