Remove Rack::Protection::EncryptedCookie
#1989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rack-session gem has equivalent functionality.
| - { ruby: 3.2, rack: stable, rack_session: head } | ||
| # https://github.com/sinatra/sinatra/issues/1988 | ||
| - { ruby: ruby-head, rack: stable, rack_session: stable, allow-failure: true } | ||
| - { ruby: 3.2, rack: head } |
Member
There was a problem hiding this comment.
Minor, unrelated: 3.3 in the matrix.
Perhaps 3.3 is meant to be here, come to think of it.
Member
Author
There was a problem hiding this comment.
3.3 is in the matrix
This line is to test with rack head (main) branch, using 3.2 for that as I'm still treating that as the "stable" Ruby :)
olleolleolle
approved these changes
Jan 15, 2024
Member
olleolleolle
left a comment
There was a problem hiding this comment.
Thanks for the PR, this brings things forward.
Nice, nice.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rack-session gem has equivalent functionality.
Close #1945