cp: fix Ioctl casting for ppc64 (Closes: #8161) #8637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
dezgeg
reviewed
Sep 14, 2025
src/uu/cp/src/platform/linux.rs
Outdated
| let dst_file = File::create(&dest)?; | ||
| let src_fd = src_file.as_raw_fd(); | ||
| let dst_fd = dst_file.as_raw_fd(); | ||
| // Using .try_into().unwrap() is required as glibc, musl & android all have different type for ioctl() |
There was a problem hiding this comment.
Can remove the now obsolete comment.
|
please run |
|
also, it would be nice to have CI for this to make sure we don't regress |
|
GNU testsuite comparison: |
|
|
have a new job in github action to build on ppc64 |
|
@sylvestre I will try, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.