Thanks to visit codestin.com
Credit goes to github.com

Skip to content

hostname: fix -d flag #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

hostname: fix -d flag #8657

merged 2 commits into from
Oct 16, 2025

Conversation

@bakanovskii
Copy link
Contributor

@bakanovskii bakanovskii commented Sep 17, 2025 •
edited by cakebaker
Loading

Fixes #8656

@AnarchistHoneybun
Copy link
Contributor

you could change the text to say "Fixes ..." or "Resolves ..." to automatically link the pr to the issue

@sylvestre
Copy link
Contributor

could you please add a test to make sure we don't regress ? thanks

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@bakanovskii
Copy link
Contributor Author

could you please add a test to make sure we don't regress ? thanks

sure! I also found https://github.com/uutils/hostname/tree/main this repo which seems to be more complete
Is this a stage repo (WIP)? Should I contribute further to hostname binary?

@bakanovskii
Copy link
Contributor Author

@sylvestre, hello! Could you please review again?

@sylvestre sylvestre merged commit 517b5fb into uutils:main Oct 16, 2025
95 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Oct 25, 2025
@bakanovskii @naoNao89
hostname: fix -d flag (uutils#8657)
31199b7 
* hostname: fix -d flag

* tests/hostname: test -d when no domain
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hostname: different behavior with -d flag

3 participants

@bakanovskii @AnarchistHoneybun @sylvestre