Thanks to visit codestin.com
Credit goes to github.com

Skip to content

clippy: re-enable semicolon_if_nothing_returned #8775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

clippy: re-enable semicolon_if_nothing_returned #8775

merged 2 commits into from
Sep 30, 2025

Conversation

@cakebaker
Copy link
Contributor

This PR re-enables the semicolon_if_nothing_returned lint and fixes two warnings in uucore by adding the missing semicolons. And in uucore/perms I refactored the code a bit so that no semicolons are necessary.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 2dfad36 into uutils:main Sep 30, 2025
97 checks passed
@cakebaker cakebaker deleted the clippy_re_enable_semicolon_if_nothing_returned branch September 30, 2025 08:13
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #8775 will not alter performance

Comparing cakebaker:clippy_re_enable_semicolon_if_nothing_returned (9b8e31a) with main (acca436)1

Summary

✅ 44 untouched
⏩ 73 skipped2

Footnotes

  1. No successful run was found on main (9b8e31a) during the generation of this report, so acca436 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cakebaker @sylvestre