Thanks to visit codestin.com
Credit goes to github.com

Skip to content

clippy: re-enable three more lints #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

clippy: re-enable three more lints #8777

merged 3 commits into from
Sep 30, 2025

Conversation

@cakebaker
Copy link
Contributor

This PR re-enables the lints if_not_else, single_char_pattern, and bool_to_int_with_if and fixes their warnings in uucore.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #8777 will degrade performances by 3.6%

Comparing cakebaker:clippy_re_enable_three_more_lints (8421df8) with main (b5ad68e)

Summary

❌ 3 regressions
✅ 49 untouched
⏩ 73 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ du_balanced_tree[(5, 4, 10)] 9.1 ms 9.3 ms -2.37%
❌ du_human_balanced_tree[(5, 4, 10)] 10.1 ms 10.4 ms -3.6%
❌ du_max_depth_balanced_tree[(6, 4, 10)] 32.2 ms 33 ms -2.26%

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sylvestre sylvestre merged commit f3d41e5 into uutils:main Sep 30, 2025
94 of 95 checks passed
@cakebaker cakebaker deleted the clippy_re_enable_three_more_lints branch September 30, 2025 09:54
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cakebaker @sylvestre