Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(client): add guide to press Esc for closing the overlay #13896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bluwy merged 4 commits into from
Jul 21, 2023
Merged

feat(client): add guide to press Esc for closing the overlay #13896

bluwy merged 4 commits into from
Jul 21, 2023

Conversation

@chaejunlee
Copy link
Contributor

@chaejunlee chaejunlee commented Jul 19, 2023

Description

Follow up of the PR #13795.

The feature for closing the vite-error-overlay with Esc key has been added.

However, the overlay doesn't say it can be closed with Esc key.

Therefore, I added little guide to let users know about this feature.

Additional context

Below is how it looks

Screenshot 2023-07-19 at 23 28 34

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Jul 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy reviewed Jul 20, 2023
View reviewed changes
@chaejunlee
Copy link
Contributor Author

chaejunlee commented Jul 20, 2023 •
edited
Loading

  1. Dark
Screenshot 2023-07-20 at 18 00 21
  • color: rgb(166, 167, 171);
  • background-color: rgb(38, 40, 44);
  • border-color: rgb(54, 57, 64);
  1. Darker
Screenshot 2023-07-20 at 18 05 16
  • color: rgb(137 138 144);
  • background-color: rgb(19 19 22);
  • border-color: rgb(51 54 61);

What do you prefer? They look almost identical though 😄.

@chaejunlee
Copy link
Contributor Author

chaejunlee commented Jul 20, 2023 •
edited
Loading

I have one last thing to confirm from the maintainers.

Should I oxford comma it? Also very minute, but I want to check before it is merged!

  1. Click outside, press Esc key or fix the code to dismiss. (AS-IS)
  2. Click outside, press Esc key, or fix the code to dismiss. (Oxford Comma)

@bluwy
Copy link
Member

bluwy commented Jul 20, 2023

Thanks! I quite like the first one. The background stands out just enough that it's shown as a keyboard key. Re comma, I usually use Oxford commas 😄 We also have a lot of usages that way in the codebase so I think we can use that too.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 20, 2023
bluwy
bluwy reviewed Jul 21, 2023
View reviewed changes
@bluwy bluwy enabled auto-merge (squash) July 21, 2023 07:33
@bluwy bluwy merged commit da389cc into vitejs:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chaejunlee @bluwy