Fix ZStream.async dropping elements on Scala Native
#9925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
reviewed
Jun 3, 2025
Contributor
kyri-petrou
left a comment
There was a problem hiding this comment.
LGTM, although given that we don't have to worry about binary incompatibility with Scala Native, I recommend changing the method signatures to replace Future[Boolean] with Unit so that we can keep the code consistent with the JVM variant
Contributor
Author
|
@kyri-petrou I have addressed the review comments. Could you please have another look when you get a chance? |
kyri-petrou
reviewed
Jun 4, 2025
managed/native/src/main/scala/zio/managed/ZManagedCompatPlatformSpecific.scala
Outdated
Show resolved
Hide resolved
hearnadam
reviewed
Jun 5, 2025
Contributor
Author
|
@kyri-petrou Can this be merged now? |
kyri-petrou
reviewed
Jun 10, 2025
streams-tests/jvm-native/src/test/scala/zio/stream/ZStreamPlatformSpecific2Spec.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kyri-petrou Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #9701
This patch fixes a race in
ZStream.asyncon Scala Native where the end marker could overtake pending chunk offers which causing some elements to be dropped. Rather than spawning a fiber for each chunk, we now enqueue each chunk synchronously(.run(...))before returning so that all 10 items are guaranteed to be in the queue beforecb.endA new test is added that runs the same 10‐element stream 100 times to confirm no elements are ever lost