Deprecate IsFatal in preparation for removal
#10140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM but I prefer to leave the approval to Kyri |
kyri-petrou
approved these changes
Aug 28, 2025
Contributor
kyri-petrou
left a comment
There was a problem hiding this comment.
Happy to deprecate it. I find it extremely difficult to believe that defining a custom IsFatal will be useful for anyone
hearnadam
added a commit
to hearnadam/zio
that referenced
this pull request
Oct 16, 2025
This is a followup, as I missed it in zio#10140
kyri-petrou
pushed a commit
that referenced
this pull request
Oct 16, 2025
This is a followup, as I missed it in #10140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsFatal is unused in any public codebase (see: #9880), has unclear semantics across functions, and has a significant performance cost. By removing configurability of
IsFatal, we can optimizeattempt,suspend, Java CS/CF interop, and more importantly the FiberRuntime itself!In this PR, I made
IsFatalitself package private, as well as the ability to add new fatals to the runtime. I also deprecated all relevant methods.After the next release, we remove checks to the FiberRef, and use a static definition for IsFatal. Maintaining binary compatibility, but removing the feature from the codebase.