fix split replays with cuts having wrong start timestamps #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Realized this solution works for my use case of just needing the correct timestamps at recording time, but would break if any other sort of editing was applied to the replay file produced, would still incorrectly offset it, but in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncut
duration: 12975
date: 1755021910454 // 8/12/2025, 9:05:10 PM
first cut
duration1: 3690
date1: 1755021910454 // 8/12/2025, 9:05:10 PM
second cut
duration2: 5956
date2: 1755021914148 // 8/12/2025, 9:05:14 PM
date ends up being first segment start + first segment length (1755021910454 + 3690)
since we have the full replay to test, can check the real full time: 12975
so the real start date should be first segment start + first segment length + second (cut) segment length,
1755021910454 + 3690 + (12975 - 3690 - 5956)
after fixes:
uncut
duration: 23803
date: 1755029588637 // 8/12/2025, 11:13:08 PM
first cut
duration1: 7876
date1: 1755029588637 // 8/12/2025, 11:13:08 PM
second cut
duration2: 3964
date2: 1755029600242 // 8/12/2025, 11:13:20 PM (includes cut time: 1755029600242 - 1755029588637 = 11605, 11605 - 7876 = 3729 <- trimmed time)
third cut
duration3: 4574
date3: 1755029607866 // 8/12/2025, 11:13:27 PM (1755029607866 - 1755029600242 = 7624, 7624 - 3964 = 3660 <- trimmed time)