SONARJAVA-5867 Fix/sonarjava 5866 s6816 nonnull parameter fp #5357
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and parameters The rule was incorrectly raising issues on fields and parameters annotated with @nonnull (from various packages like org.jspecify.annotations.NonNull or edu.umd.cs.findbugs.annotations.NonNull). Since @nonnull indicates the value cannot be null, requesting a default null value doesn't make sense. Fixed by checking the NullabilityType and only raising issues when the annotation is actually nullable (WEAK_NULLABLE or STRONG_NULLABLE), not when it's NON_NULL, UNKNOWN, or NO_ANNOTATION. Prefer not raising an issue when nullability type is unknown. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5867
Part of