fix: flaky tests due to imprecision in floating point calculation and performance test setup #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid floating point conversion imprecision
Fix linter error with black
Ensure URL encoding takes enough time so that cached version is measurably 10x faster
coryan
previously approved these changes
Nov 14, 2025
vchudnov-g
requested changes
Nov 14, 2025
tests/unit/gapic/test_method.py
Outdated
| result = wrapped_method(timeout=22) | ||
| # Using "result = wrapped_method(timeout=22)" fails since wrapped_method | ||
| # does floating point calculations that results in 21.987.. instead of 22 | ||
| result = wrapped_method(timeout=timeout.ConstantTimeout(22)) |
Contributor
There was a problem hiding this comment.
Since ConstantTimeout is deprecated, we should the fdollowing:
- with this code change, rename the test method to
test_wrap_method_with_overriding_constant_timeout - either do the following now or create an issue (and put it in a TODO here) to do this separately: recreate
test_wrap_method_with_overriding_timeout_as_a_number()that actually does overwrite the timeout with a number, and make that test method robust enough to handle the floating-point computations that occur inTimeToDeadlineTimeout, which is where the numeric timeout override gets processed.
Change code to skip flaky test and add a new test that uses a constant timeout instead of a number to check that override works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to validate test fix