Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BlazingTwist
Copy link

@BlazingTwist BlazingTwist commented Nov 4, 2025

Fixes an oversight where #704 only correctly applied to scalar dependency values.
Previously, for editors with multiple dependencies, each with multiple possible values, only the last dependency was considered.
Now all dependencies must be fulfilled, bringing the behaviour in-line with the behaviour of scalar dependency values.

Manual Test Case

https://json-editor.github.io/json-editor/?data=N4Ig9gDgLglmB2BnEAuUBXRBTA+vAhgLa75RQBOMARulFsihelgDQgTliHQ5VYBmYcrgAmWADZY6qJqxCZRA/OnFQcAN3zjmDWW0L4AHjjHQAFqgAMbGmQQ5EUUrkJgxqAIxsAxvmwOsJBhYdVwOSCxyKABPAPxybwtGcmY2RDMwAHccSM5yBhAYeDpyfG9YBBA2cO41CD86HANjSXgAcygzHGEysywRVH4tbDZhV1CcIfF/cIhI2HpB4blAwQTcbwRHJem5SDUinEyYETapVBBErG8AayowQyrCzfhxagvBYvxM+i4sAFYnmAqAAra5qcT4aJgWgXeBCAziJ6IK4GVCgYQAR3QMGEAxQAG0QHRHB4cPgniSoGSqJT6FAAEzkumOJm0gC61U4cyiMEWaGJ9LJFIFMTmF3uYEk+HgIAAvmwqTT0cTouKUCBJdLZQrBaTyeT4CJeCqxVgJWApVgZUDoHAkCrTIExPBvHyGKAlczkqk9dSTT6sHLg4r6UyRZ61eaNUU6GdyE9AuhCKgCdYvAz2bqqWzTVGLrGsPHE/Bk6n0yxM9mwwaZcbaaL8xqtdbZWx9vaPSAnUbAm7+Z6ayKCRnOX7c4TR8GQ6r1eBQeD5Yq+sQLWAoI5ShAACzyuVAA===

Observe that previously, test2_a_and_b would show for a in (0,1,2) && b in (1,2).
Observe that previously and now, test1_a_and_b only shows if a==true && b==true.
Observe that now, test2_a_and_b only shows if a in (1,2) && b in (1,2).

Template

Q A
Is bugfix? ✔️
New feature?
Is backward-compatible? ✔️
Tests pass?
Fixed issues
Updated README/docs?
Added CHANGELOG entry? ✔️

Why are the tests failing?

Because tests/README.md is either wrong, or my machine shows unexpected bevahiour, and I don't care to look deeper into it.

docker-compose exec node bash

root@a1f04d5153c1:/repo/tests/codeceptjs# npm run build
    webpack 5.91.0 compiled successfully in 22362 ms
root@a1f04d5153c1:/repo/tests/codeceptjs# cd tests/
    bash: cd: tests/: No such file or directory
root@a1f04d5153c1:/repo/tests/codeceptjs# codeceptjs run
    Error: Can not load config from /repo/tests/codeceptjs/codecept.config.js

// second spray-and-pray attempt based on 'codecept.config.js' existing in /repo
root@a1f04d5153c1:/repo# npm run build
    webpack 5.91.0 compiled successfully in 19072 ms
root@a1f04d5153c1:/repo# codeceptjs run
    Error: Failed to launch chrome!
    /repo/node_modules/puppeteer/.local-chromium/linux-686378/chrome-linux/chrome: error while loading shared libraries: libX11-xcb.so.1: cannot open shared object file: No such file or directory

Okay, I lied. I looked a little deeper:

  • codecept.conf.jsf includes helpers.Puppeteer.show = true which seems wrong for a headless environment.
  • even when disabling that option, codecept is not looking in the right place for pages. As far as I can tell, it should look for http://localhost:9100/tests/pages/* but it doesn't.

Fixes an oversight where json-editor#704 only correctly applied to scalar dependency values.
Previously, for editors with multiple dependencies, each with multiple possible values, only the last dependency was considered.
Now all dependencies must be fulfilled, bringing the behaviour in-line with the behaviour of scalar dependency values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant