Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CFn: raise validation error if the template is not valid #13377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CFn: raise validation error if the template is not valid #13377

wants to merge 1 commit into from

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Nov 13, 2025

Motivation

When submitting invalid templates, the CloudFormation template parser raises a 500 internal server error rather than a 400 validation error.

Changes

Raise validation error instead

Tests

Related

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Test Results - Preflight, Unit

22 309 tests  ±0   20 555 ✅ ±0   6m 45s ⏱️ +29s
     1 suites ±0    1 754 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 85010a1. ± Comparison against base commit c1abe8d.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 27s ⏱️ +8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 85010a1. ± Comparison against base commit c1abe8d.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 8s ⏱️ - 1h 26m 44s
586 tests  - 4 352  471 ✅  - 4 088  114 💤  - 265  1 ❌ +1 
588 runs   - 4 352  471 ✅  - 4 088  116 💤  - 265  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 85010a1. ± Comparison against base commit c1abe8d.

This pull request removes 4353 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_templates ‑ test_create_stack_invalid_yaml_template_should_fail

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   49m 7s ⏱️ - 1h 51m 53s
610 tests  - 4 702  496 ✅  - 4 277  113 💤  - 426  1 ❌ +1 
616 runs   - 4 702  496 ✅  - 4 277  119 💤  - 426  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 85010a1. ± Comparison against base commit c1abe8d.

This pull request removes 4703 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_templates ‑ test_create_stack_invalid_yaml_template_should_fail

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Test Results - Alternative Providers

585 tests   - 875   330 ✅  - 477   23m 36s ⏱️ - 12m 44s
  1 suites  -   4   254 💤  - 399 
  1 files    -   4     1 ❌ +  1 

For more details on these failures, see this check.

Results for commit 85010a1. ± Comparison against base commit c1abe8d.

This pull request removes 876 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_alarm_lambda_target
…

tests.aws.services.cloudformation.api.test_templates ‑ test_create_stack_invalid_yaml_template_should_fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonrw