Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ZJIT: Add HIR Comment Insn for debugging #15166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZJIT: Add HIR Comment Insn for debugging #15166

wants to merge 1 commit into from
+26 −4

Conversation

@rwstauner
Copy link
Contributor

@rwstauner rwstauner commented Nov 13, 2025

The comment shows up in HIR, LIR, and disasm:

bb2(v8:BasicObject, v9:BasicObject):
  # def_type 0
  # VM_METHOD_TYPE_ISEQ

--

    PatchPoint Exit(PatchPoint(NoTracePoint))
    # Insn: v19 # def_type 0
    # Insn: v20 # VM_METHOD_TYPE_ISEQ

--

  0x1235240f8: nop
  # Insn: v19 # def_type 0
  # Insn: v20 # VM_METHOD_TYPE_ISEQ

I found this useful as an alternative to println! if you want the message to stay by the other blocks you are inserting.

@rwstauner
ZJIT: Add HIR Comment Insn for debugging
236f50d 
The comment shows up in HIR, LIR, and disasm:

    bb2(v8:BasicObject, v9:BasicObject):
      # def_type 0
      # VM_METHOD_TYPE_ISEQ

--

        PatchPoint Exit(PatchPoint(NoTracePoint))
        # Insn: v19 # def_type 0
        # Insn: v20 # VM_METHOD_TYPE_ISEQ

--

      0x1235240f8: nop
      # Insn: v19 # def_type 0
      # Insn: v20 # VM_METHOD_TYPE_ISEQ
@matzbot matzbot requested a review from a team November 13, 2025 03:36
@launchable-app
Copy link

launchable-app bot commented Nov 13, 2025

❌ 2/66949 Tests Failed

test/rubygems/test_gem_package_tar_header_ractor.rb#test_decode_in_ractor 
Error:
TestGemPackageTarHeaderRactor#test_decode_in_ractor:
Test::Unit::ProxyError: execution of Test::Unit::CoreAssertions#assert_separately expired timeout (10 sec)
pid 9784 exit 0
| 

    D:/a/ruby/ruby/src/test/rubygems/test_gem_package_tar_header_ractor.rb:36:in 'TestGemPackageTarHeaderRactor#test_decode_in_ractor'
test/rubygems/test_gem_package_tar_header_ractor.rb#test_encode_in_ractor 
Error:
TestGemPackageTarHeaderRactor#test_encode_in_ractor:
Test::Unit::ProxyError: execution of Test::Unit::CoreAssertions#assert_separately expired timeout (10 sec)
pid 4708 exit 0
| 

    D:/a/ruby/ruby/src/test/rubygems/test_gem_package_tar_header_ractor.rb:48:in 'TestGemPackageTarHeaderRactor#test_encode_in_ractor'

[-> View Test suite health in main branch]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rwstauner