core: support reload failure reporting and do so ourselves #39745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0733bd to
7c16026
Compare
Up until now there's no sane way for notify-reload services to report failure to service manager. While we encourage handling such failure gracefully in the main process, the reload job should almost certainly fail. Hence, let's introduce a way for service to communicate the fact. RELOADING=-1 is expected to be sent alongside either READY=1 or STOPPING=1, for gracefully handled errors and fatal ones, respectively. This also ensures older service manager properly behaves without support for the message.
…_dbus No functional change, preparation for later commits. This also makes the logic consistent with varlink call.
c5c4602 to
506b489
Compare
With the previous commit, Manager.pending_reload_message_* won't be lingering around if reload fails. IOW, they are set iff MANAGER_IS_RELOADING or send_reloading_done is true.
506b489 to
25b266f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.