Description

Major changes:

TFTP/DHCP Enhancements:

• Add dynamic hardware type handling in DHCP option 209 (PXELinuxConfigFile)
• Implement TFTP handler for pxelinux.cfg/- format
• Add U-Boot client support (option 60) and architecture handling
• Make Raspberry Pi detection public (IsRaspberryPI)
• Add proper architecture-specific bootfile handling (ARM64, ARM32)

TFTP Server Refactoring:

• Extract TFTP multiplexer to smee/internal/tftp package
• Add pattern-based routing with regex support
• Implement middleware for logging and request tracking
• Add hook file handler for serving from cache directory
• Add TFTP configuration options (Anticipate, CacheDir)
• Consolidate TFTP handlers with HTTP handlers

Hook Service (NEW):

• Add hook/hook.go for OCI image management
• Support for pulling and serving hook files via HTTP/TFTP
• Background image pulling with caching
• Comprehensive test coverage (765 lines)

Code Quality & Testing:

• Add extensive tests for TFTP pattern matching (tftp_test.go)
• Fix test compatibility issues (macOS loopback interface)
• Add tests for hardware type validation and error handling
• Improve shell script robustness (proper quoting, shellcheck compliance)

Protobuf & Formatting:

• Regenerate protobuf files with proper import ordering
• Fix indentation in .proto files (edition 2023 format)
• Standardize code formatting across shell scripts

Minor Fixes:

• Fix naked return statements in xff.go
• Clean up unused code and improve error handling
• Add proper platform-agnostic loopback interface detection
• Fix syslog test for available port usage

Breaking Changes:

• TFTP server now requires explicit handler registration
• Binary TFTP handler moved from binary/tftp.go to binary.Handler.HandleTFTP
• Script TFTP handler now supports pxelinux.cfg format

This refactoring improves modularity, adds U-Boot support, and prepares the codebase for more flexible boot configuration scenarios including ARM devices and network appliances.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
  This pull request makes significant improvements to the CI/CD pipeline, build tooling, and containerization for the project. The changes modernize the workflow by introducing GoReleaser for builds and releases, streamline binary management, improve caching and linting, and enhance Docker image creation with statically linked dependencies. Additionally, the Makefile and configuration files have been refactored for clarity and maintainability.

CI/CD Workflow Overhaul

• Replaces custom build and artifact upload steps in .github/workflows/ci.yaml with GoReleaser for building, packaging, and releasing binaries and container images. This includes signing images with Cosign and simplifying the workflow steps and dependencies. [1] [2]
• Refactors jobs: introduces dedicated lint, generate, validation, and validate-helm-chart jobs; improves caching strategies and removes redundant cache restore/save steps. [1] [2]
• Removes the release-notes job and its artifact handling, further simplifying the release process.

Build Tooling and Makefile Improvements

• Integrates GoReleaser as the primary build tool in the Makefile, with new variables and targets for tool binaries, and updates the default build target to use GoReleaser.
• Refactors tool binary paths and names for clarity and consistency, moving them to a dedicated bin directory and updating related variables.
• Adds logic for UPX compression based on platform, improving binary size management.

Docker Image and Binary Management

• Updates Dockerfile.tinkerbell to use a multi-stage build for statically compiling ipmitool, ensuring the final image contains a static binary and required certificates.
• Updates Dockerfile.agent to use the new binary path structure for copying agent binaries.

Configuration and Linting Adjustments

• Updates .golangci.yml to increase the minimum complexity threshold for the gocognit linter.
• Updates Helm chart repository variables in the Makefile to use a dynamic repository owner.

These changes collectively modernize and simplify the build and release process, improve maintainability, and ensure consistent, statically linked binaries and container images.

• provided instructions on how to upgrade
  This pull request introduces significant improvements to the build, release, and CI/CD pipeline for the project. The main changes include a migration to GoReleaser for building and publishing binaries and container images, a refactor of the GitHub Actions workflow to streamline jobs and caching, and an update to the Dockerfiles for more reliable static builds. It also introduces UPX compression for binaries and updates Makefile tooling and variables for better maintainability.

Build and Release Automation:

• Added a new .goreleaser.yaml configuration to automate building, compressing, and publishing binaries and container images using GoReleaser, including UPX compression and static linking for Linux binaries.
• Updated the Makefile to use GoReleaser for builds, added UPX compression logic, and refactored tool binary management for easier upgrades and caching. [1] [2] [3]

CI/CD Workflow Refactor:

• Refactored .github/workflows/ci.yaml to replace custom build and cache steps with GoReleaser, streamlined job structure (lint, generate, validation, build/publish), and improved caching and artifact handling. [1] [2] [3] [4] [5]

Container/Docker Improvements:

• Updated Dockerfile.tinkerbell to build a statically linked ipmitool binary in a multi-stage process for improved reliability and reproducibility.
• Changed Dockerfile.agent to use the new build output directory structure for binaries.

Configuration Updates:

• Updated Helm chart repository naming logic in the Makefile to use a configurable repository owner.
• Increased the complexity threshold for the gocognit linter in .golangci.yml for more robust code analysis.