Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add RegisterCatchAll to zen framework #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: refactor/tenant-gateways
Choose a base branch
from
Draft

feat: add RegisterCatchAll to zen framework #4328

wants to merge 2 commits into from
+34 −2

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Nov 13, 2025

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f48fc43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dashboard Ready Ready Preview Comment Nov 13, 2025 10:22am
engineering Ready Ready Preview Comment Nov 13, 2025 10:22am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/zen-catchall

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Flo4604 Graphite App
Copy link
Member Author

Flo4604 commented Nov 13, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 13, 2025
Closed
Draft
Draft
Draft
Flo4604 and others added 2 commits November 13, 2025 11:18
@Flo4604
feat: add RegisterCatchAll to zen framework
f475008
@Flo4604 @claude
refactor: replace RegisterCatchAll with CATCHALL constant
f48fc43 
Instead of having a separate RegisterCatchAll function, routes can now return
zen.CATCHALL from their Method() to indicate they should handle all HTTP methods.
This simplifies the API by using a single RegisterRoute function for both
regular and catch-all routes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr will be requested when the pull request is marked ready for review perkinsjr is a code owner

@chronark chronark Awaiting requested review from chronark chronark will be requested when the pull request is marked ready for review chronark is a code owner

@imeyer imeyer Awaiting requested review from imeyer imeyer will be requested when the pull request is marked ready for review imeyer is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Flo4604