-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update codecs from v3.14.2 #6845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e1c1ebb to
6f55cae
Compare
|
@moreal can we merge this? |
@ShaharNaveh we can but I realized there are more related files (this PR has changed only codecs and test_codecs). If it is okay to separate them into two PR, this can be merged at this status. |
f307088 to
b23fdc2
Compare
b23fdc2 to
bdaae4f
Compare
Lib/test/multibytecodec_support.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding these new series of tests seems not the best idea for initial updating codec. Could you remove these new files and update only codec? that will be better to update codec right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll revert them.
cd7bf6b to
fe889e7
Compare
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/codecs.py dependencies:
dependent tests: (101 tests)
Legend:
|
Note
I'm dogfooding for #6827