Thanks to visit codestin.com
Credit goes to ampcode.com

Sign In Sign Up

Optimize observeThreadGuidanceFiles return type

Quinn
Quinn Slack • @sqs
 10mo ago
sourcegraph/amp sqs/rules
Make observeThreadGuidanceFiles return Omit<ResolvedGuidanceFile, 'content'>[] and remove that field from its return value, and update the tests. Note that it is omitted because this is used in places that do not need the file contents, and this saves on data transferred over the webview API.

I'll help you modify observeThreadGuidanceFiles to omit the content field and update the tests accordingly.

Ran tool todo_write
Ran tool todo_write
Explored 1 file
Ran tool todo_write

Now I'll modify the observeThreadGuidanceFiles function to return the type without the content field and update its implementation:

Edited guidance-files.ts
+1
-1

Now I need to update the implementation to map the resolved guidance files to exclude the content field:

Edited guidance-files.ts
+6
Ran tool todo_write

Now I need to find the tests for this function:

Explored 1 file, 1 search

Now I need to update the test expectations to not expect the content field. I can see that the tests are checking toMatchObject which should still pass if we just remove the content field from what gets returned. However, I need to ensure that the test expectations are updated properly.

Looking at the tests, I can see they primarily check for uri and type properties, so the main change needed is in the mock of resolveGuidanceFiles to not include content in the return value, and update any test assertions that might check for the content field.

Edited guidance-files.test.ts

Let me check if any tests are explicitly checking for the content field:

Explored 2 searches

Good, the tests don't seem to be checking for the content field explicitly. Let me run the tests to see if they pass with my changes:

Ran tool todo_write

Great! The tests are passing. Now let me check for any other uses of observeThreadGuidanceFiles in the codebase to see if they need to be updated:

Explored 1 search

Let me check the worker usage to see if it needs to be updated:

Explored 1 file

Let me check what the threadGuidanceFiles method should return to see if there are any type expectations:

Explored 1 search

I need to check the webview API type definition to see if it needs to be updated:

Explored 1 file

I need to update the webview API type to match the new return type:

Edited webview-api.ts
+1
-1

Now let me run a typecheck to ensure there are no type errors:

This error seems unrelated to my changes - it's about an AbortSignal issue. Let me run the tests to make sure my changes don't break anything:

Great! All tests are passing. Now let me run the full build check to make sure everything is working correctly: