commit | b9106236b85aecfbf2a78be286305fb8717ef4bf | [log] [tgz] |
---|---|---|
author | Sida Zhu <[email protected]> | Fri Apr 19 10:43:09 2024 |
committer | Chromium LUCI CQ <[email protected]> | Fri Apr 19 10:43:09 2024 |
tree | d2e0dddad8492b73f5858062214011b2ae306813 | |
parent | d5538e15c3b820074054ce93be6984a61387c6bb [diff] |
[Canary 6427] Revert "Audio: Always choose hardware layout as output layout" This reverts commit 620f17d013321ee9576546bab37f178f299b4821. Reason for revert: cause https://issues.chromium.org/issues/335325895 Original change's description: > Audio: Always choose hardware layout as output layout > > When we playback a 4.0 channel layout audio, and when we have > a 5.1 channel layout Audio MIDI setup, their should be an upmix: > > L -> L, > R -> R, > C -> C, > BC -> upmix to SL and SR > > In this case, we expect the output channel layout always be 5.1, > but the previously logic limited us to use 4.0 layout, which > causes the silent back center channel. > > To fix the bug, we should always use hardware layout as output > layout no matter what. > > Bug: 40809490 > Bug: 41495709 > Bug: 41487675 > Change-Id: If9f0ad0144c83a722622ea0e6f51286b9d8fc8f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320653 > Reviewed-by: Thomas Guilbert <[email protected]> > Commit-Queue: Sida Zhu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1264756} (cherry picked from commit 64cc0bf713bb1048bacad73dbeff45ecc3d9ba56) Bug: 335325895 Bug: 40809490 Bug: 41495709 Bug: 41487675 Change-Id: Ied87a4c3714fb1ddfff71b509a2f1297cdb7ba7d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464646 Reviewed-by: Thomas Guilbert <[email protected]> Commit-Queue: Sida Zhu <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1289671} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466095 Auto-Submit: Daniel Yip <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Daniel Yip <[email protected]> Cr-Commit-Position: refs/branch-heads/6427@{#6} Cr-Branched-From: 583df5d3b1921d2120277253426db7a9a2ab444d-refs/heads/main@{#1289563}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.