commit | 045ab76f62116023b2fbcb25d79a5ea74842eeb6 | [log] [tgz] |
---|---|---|
author | Daniel Yip <[email protected]> | Tue Dec 03 15:20:00 2024 |
committer | Chromium LUCI CQ <[email protected]> | Tue Dec 03 15:20:00 2024 |
tree | a6ad59049b1754de52306bc9550fb2af831cd6bf | |
parent | c07b3d141627782b1d3a399672810049b1210920 [diff] |
Revert "Convert HeapProfiler JSON params to regular FeatureParams" This reverts commit 1c0d6593cba47597f8def6b19be1d05d064d4c1f. Reason for revert: Caused crash on launch in Canary b/382002928 Original change's description: > Convert HeapProfiler JSON params to regular FeatureParams > > Now that the heap profiler is controlled centrally from the browser > process, many params are redundant. This simplifies the params that > were in per-process JSON dicts: > > * `is_supported` is no longer needed. To disable in a subprocess, set > its snapshot probability (eg. `gpu-prob-pct`, `renderer-proc-pct`) > to 0. To disable in the browser process, disable the > "HeapProfilerReporting" feature. > * `stable_probability`, `nonstable_probability` and > `collection_interval` now only affect the browser process, so make > them global FeatureParams. > * `sampling_rate_bytes` is split into separate FeatureParams for each > process (eg. `gpu-sampling-rate-bytes`, `renderer-sampling-rate- > bytes`). > > Also removes the test that enables profiler reports in a child process > but not the browser process, since there's no longer any combination > of feature params that can do this. (Since HeapProfilerCentralControl > launched, the test only checked that the giving params that enabled a > child process without enabling the browser did nothing.) > > Bug: 40840943 > Change-Id: I070d8ec1035ab6c21fe676e3a44c15e199508b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6056270 > Commit-Queue: Joe Mason <[email protected]> > Reviewed-by: Sean Maher <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1390539} Bug: 40840943, 382002928 Change-Id: I5a0bd185d48620983348a13944ff7cc212b29e13 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063591 Owners-Override: Ben Mason <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Daniel Yip <[email protected]> Auto-Submit: Daniel Yip <[email protected]> Cr-Commit-Position: refs/branch-heads/6874@{#4} Cr-Branched-From: e0cc0017a3c6366e11d02feb227c5d3adc62b2a8-refs/heads/main@{#1390761}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.