CVS log for src/usr.sbin/bgpd/logmsg.c

Up to [local] / src / usr.sbin / bgpd

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.16 / (download) - annotate - [select for diffs], Tue Sep 9 12:42:04 2025 UTC (2 weeks, 5 days ago) by claudio
Branch: MAIN
CVS Tags: HEAD
Changes since 1.15: +41 -2 lines
Diff to previous 1.15 (colored)

Log optional NOTIFICATION data for UPDATE errors if verbose is set

The additional data can help identify why a NOTIFICATION was triggered
and help fix the error without having to use tcpdump to get the wire
data.
OK sthen@ tb@

Revision 1.15 / (download) - annotate - [select for diffs], Thu Aug 21 15:15:25 2025 UTC (5 weeks, 3 days ago) by claudio
Branch: MAIN
Changes since 1.14: +9 -12 lines
Diff to previous 1.14 (colored)

Switch peer FSM state early in change_state()

Update the peer state and prev_state first, then do all the additional
actions which now can use peer->state and peer->prev_state.
As a side effect mrt_state_dump becomes trivial and log_statechange()
switches the arguments around for its 'don't clutter the logs' magic.
OK tb@ (long time ago)

Revision 1.14 / (download) - annotate - [select for diffs], Mon May 20 10:00:00 2024 UTC (16 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_7_BASE, OPENBSD_7_7, OPENBSD_7_6_BASE, OPENBSD_7_6
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Tabs on empty line

Revision 1.13 / (download) - annotate - [select for diffs], Fri Mar 22 15:41:34 2024 UTC (18 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.12: +14 -8 lines
Diff to previous 1.12 (colored)

Rework the cease shutdown reason to work in both directions by looking
at the ibuf payload passed to log_notification().
Because of this move ibuf_get_string() and the log_notification() call
in parse_notification().
OK tb@

Revision 1.12 / (download) - annotate - [select for diffs], Fri Mar 22 07:19:28 2024 UTC (18 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.11: +32 -2 lines
Diff to previous 1.11 (colored)

Rework parse_notification() to use the ibuf API for everything.

While there fix the RFC5492 handling of ERR_OPEN_CAPA (the current code
has the logic inversed). ERR_OPEN_CAPA is there to signal that a needed
capability is missing in our OPEN message. Just add the handling of
ERR_OPEN_CAPA to log_notification().

Also rework the handling of the shutdown reason and move the printing
into log_notification().

OK tb@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jan 16 13:15:31 2024 UTC (20 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

Switch session_notification() over to use a struct ibuf to carry the
extra data. With this IMSG_UPDATE_ERR can use the new imsg API.

Introduce session_notification_data() for the few cases where there
is no ibuf readily available.

OK tb@

Revision 1.10 / (download) - annotate - [select for diffs], Sat Oct 14 09:46:14 2023 UTC (23 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.9: +19 -20 lines
Diff to previous 1.9 (colored)

Rewrite log_peer_info() and log_peer_warn[x]()

Passing the peer description as part of the format string was a bad idea
since the peer description may include some % signs (e.g. for link local
IPv6 addresses). So instead of asprintf a new fmt string use vasprintf
to get the message and then use logit("%s: %s", peer_info, msg).
OK tb@

Revision 1.9 / (download) - annotate - [select for diffs], Wed Aug 24 17:14:02 2022 UTC (3 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

Put the 'connection from non-peer' log message behind a verbose logging check.
In many cases the message is just flooding the logs. In some cases it may
help to identify a missing neighbor for those cases log verbose can be used.
OK deraadt@ denis@

Revision 1.8 / (download) - annotate - [select for diffs], Thu Jul 28 13:11:48 2022 UTC (3 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored)

whitespace found during a read-thru; ok claudio

Revision 1.7 / (download) - annotate - [select for diffs], Tue Jun 28 11:42:41 2022 UTC (3 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.6: +13 -7 lines
Diff to previous 1.6 (colored)

Check for entries in the suberror names arrays that are NULL. Handle them
like other unknown ones. Also KNF the code a bit.
Was OK tb@ some time ago

Revision 1.6 / (download) - annotate - [select for diffs], Sun Feb 6 09:51:19 2022 UTC (3 years, 7 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)

Switch from u_intX_t types to stdint.h uintX_t. Mostly mechanical with
a few reindents.
OK florian@ tb@

Revision 1.5 / (download) - annotate - [select for diffs], Thu May 27 08:27:48 2021 UTC (4 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.4: +7 -1 lines
Diff to previous 1.4 (colored)

bgpd(8) will soon support ADD-PATH (RFC7911) and enhanced route refresh
(RFC7313). This is the frist step toward this.

It adds the capability parsers for the two no capabilities, extends the
capability struct and adds the capability negotiation bits.
The route refresh message parser and generator are extended to support
the BoRR and EoRR message. Also add the new NOTIFICATION type and subtype
for the route refresh message.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Feb 18 09:43:57 2019 UTC (6 years, 7 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

Do not depend on the length field of struct sockaddr instead pass the
length to the various functions needing it. Helps portability.
OK benno@

Revision 1.3 / (download) - annotate - [select for diffs], Sun May 28 20:14:15 2017 UTC (8 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.2: +23 -7 lines
Diff to previous 1.2 (colored)

Introduce log_peer_info() and make log_peer_warn() log at LOG_ERR instead
of LOG_CRIT (which should only be used for fatal).
OK benno@

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jan 24 04:22:42 2017 UTC (8 years, 8 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

sync log.c from relayd et al to bgpd.

there is still a little difference regarding handling of the verbosity
value that will be handled later.

ok claudio@ florian@

Revision 1.1 / (download) - annotate - [select for diffs], Fri Sep 2 14:04:51 2016 UTC (9 years ago) by benno
Branch: MAIN

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.