Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented May 23, 2021

Changes

  • Remove the options skip-stale-issue-message and skip-stale-pr-message
  • Change the behaviour to allow to process the issues and PRs when the options stale-issue-message and stale-pr-message are unset since it should be optional to comment and should not be a reason to exit the workflow
  • Change the condition to add a comment when stale by simple checking that the options stale-issue-message and stale-pr-message are set

Other

Closes #405
Closes #455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message

@C0ZEN C0ZEN requested a review from a team as a code owner May 23, 2021 18:26
@C0ZEN
Copy link
Contributor Author

C0ZEN commented May 23, 2021

@luketomlinson good candidate for a major release!

Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Make it a little simpler

@luketomlinson
Copy link
Collaborator

@C0ZEN Some conflicts now ☝️

C0ZEN added 3 commits May 25, 2021 19:56
Closes actions#405
Closes actions#455

BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
also lint some files
@C0ZEN C0ZEN force-pushed the feature/remove-skip-message-options branch from b251314 to ad75fc3 Compare May 25, 2021 18:00
@C0ZEN
Copy link
Contributor Author

C0ZEN commented May 25, 2021

@luketomlinson handled

@luketomlinson luketomlinson merged commit 6ec637d into actions:main May 25, 2021
@C0ZEN C0ZEN deleted the feature/remove-skip-message-options branch May 25, 2021 18:15
@C0ZEN
Copy link
Contributor Author

C0ZEN commented May 25, 2021

@luketomlinson thanks. Did you see my message about the breaking change?

@luketomlinson
Copy link
Collaborator

yep @C0ZEN I think we can major version here pretty soon

@C0ZEN
Copy link
Contributor Author

C0ZEN commented May 25, 2021

So, what about #414?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants