Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Move some build steps to gulp#12127

Merged
JLHwung merged 9 commits intobabel:mainfrom
JLHwung:move-build-process-to-gulp
Dec 10, 2020
Merged

Move some build steps to gulp#12127
JLHwung merged 9 commits intobabel:mainfrom
JLHwung:move-build-process-to-gulp

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 30, 2020 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? When @babel/types definitions are updated, make watch does not rebuild type helpers and typings
License MIT

This PR moves build scripts from Makefile to gulp -- so we can implement watch utilities for some tasks. It does not remove Makefile but should be easier for Windows contributors: The plan is to have gulp watch and yarn jest practical replacement for make watch and make test.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 30, 2020
JLHwung
JLHwung commented Sep 30, 2020
View reviewed changes
scripts/utils/formatCode.js
prettierConfig.filepath = filename;
prettierConfig.parser = "babel";

if (process.env.CI && parseInt(process.versions.node, 10) < 10) {
Copy link
Contributor Author

@JLHwung JLHwung Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are removed since we run build scripts on latest node only 😛.

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 30, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34416/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 30, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8f3081:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung marked this pull request as ready for review October 1, 2020 19:52
@JLHwung JLHwung mentioned this pull request Oct 1, 2020
Merged
@JLHwung JLHwung requested a review from nicolo-ribaudo October 8, 2020 13:44
JLHwung
JLHwung commented Oct 8, 2020
View reviewed changes
Gulpfile.js
gulp.series("build-dev", function watch() {
gulp.watch(defaultSourcesGlob, gulp.task("build-no-bundle"));
gulp.watch(
babelStandalonePluginConfigGlob,
Copy link
Contributor Author

@JLHwung JLHwung Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you edit packages/babel-standalone/scripts/pluginConfig.json, packages/babel-standalone/src/generated/plugins.js will be automatically generated so you don't have to run (and remember to!) make generate-standalone again.

JLHwung
JLHwung commented Oct 8, 2020
View reviewed changes
Gulpfile.js Outdated
);
gulp.watch(
buildTypingsWatchGlob,
gulp.parallel("build-typings", "generate-type-helpers")
Copy link
Contributor Author

@JLHwung JLHwung Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you edit packages/babel-types/src/definitions or ./packages/babel-types/scripts/generators/*.js, the @babel/types helpers and typings will be regenerated automatically. So you don't have to run (and remember to!) make generate-type-helpers && make build-typings again.

@JLHwung JLHwung force-pushed the move-build-process-to-gulp branch from ed39a04 to 54204d5 Compare October 9, 2020 18:44
nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 12, 2020
View reviewed changes
@JLHwung JLHwung force-pushed the move-build-process-to-gulp branch 2 times, most recently from 3d2111d to bb81f5f Compare October 19, 2020 20:11
@JLHwung JLHwung force-pushed the move-build-process-to-gulp branch from bb81f5f to ca59046 Compare November 10, 2020 14:41
@JLHwung JLHwung force-pushed the move-build-process-to-gulp branch from ca59046 to f8f3081 Compare November 26, 2020 22:59
@nicolo-ribaudo nicolo-ribaudo requested a review from hzoo December 8, 2020 23:20
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 9, 2020

This PR introduces some problems with the generated @babel/types TS typings (see the failing e2e test).
Probably it makes sense to wait until #12431 is merged, since that PR changes how .d.ts files are generated.

@JLHwung
Copy link
Contributor Author

JLHwung commented Dec 9, 2020

I can partially revert types generation so we can get it merged.

@JLHwung JLHwung force-pushed the move-build-process-to-gulp branch from f8f3081 to c088350 Compare December 9, 2020 14:56
@JLHwung JLHwung merged commit e5b2680 into babel:main Dec 10, 2020
@JLHwung JLHwung deleted the move-build-process-to-gulp branch December 10, 2020 17:25
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@existentialism existentialism Awaiting requested review from existentialism

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JLHwung @babel-bot @nicolo-ribaudo @hzoo