Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Sep 19, 2016

This fixes a TODO in Enhancer: the assumption that a bridge's parameters
are assignable to the target's parameters doesn't hold in certain
cross-compilation scenarios.

The included test case fails with a VerifyError if the checkcasts are
omitted.

Also, make BridgeMethodResolver use the same class loader as Enhancer to
make it easier to test.

This fixes a TODO in Enhancer: the assumption that a bridge's parameters
are assignable to the target's parameters doesn't hold in certain
cross-compilation scenarios.

The included test case fails with a VerifyError if the checkcasts are
omitted.

Also, make BridgeMethodResolver use the same class loader as Enhancer to
make it easier to test.
@sameb
Copy link
Contributor

sameb commented Sep 19, 2016

Thanks Liam! Do you know if this fixes the same issue described in #89?

On Mon, Sep 19, 2016, 6:34 PM Liam Miller-Cushon [email protected]
wrote:

This fixes a TODO in Enhancer: the assumption that a bridge's parameters
are assignable to the target's parameters doesn't hold in certain
cross-compilation scenarios.

The included test case fails with a VerifyError if the checkcasts are
omitted.

Also, make BridgeMethodResolver use the same class loader as Enhancer to

make it easier to test.

You can view, comment on, or merge this pull request online at:

#90
Commit Summary

  • Add checkcasts for arguments of invoked bridges

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#90, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACC7EhfrGH_1YRzLU-VCJkusnJm4grI9ks5qrw3dgaJpZM4KBCcc
.

@cushon cushon mentioned this pull request Sep 20, 2016
@raphw raphw merged commit a077522 into cglib:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants